Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block comments in SFZ file fail to load #195

Closed
alcomposer opened this issue Apr 20, 2020 · 1 comment
Closed

Block comments in SFZ file fail to load #195

alcomposer opened this issue Apr 20, 2020 · 1 comment

Comments

@alcomposer
Copy link
Collaborator

alcomposer commented Apr 20, 2020 •
edited
Loading

Issue

Block comments starting with /* and ending with */ cause Sfizz to not load the SFZ file, and print to Ardour log:
2020-04-20T17:36:34 [ERROR]: [sfizz] Error with EXAMPLE_FILE; no file should be loaded

Removing block comments fixes issue. Comments starting with // do not exhibit this issue.

Versions:

Latest Sfizz Git
Latest Ardour Git

Example File:

/*
*/
<region> sample=*sine
@jpcima jpcima mentioned this issue Apr 20, 2020
Merged
@jpcima
Copy link
Collaborator

jpcima commented Apr 20, 2020

It's fixed starting with commit c2767b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alcomposer @jpcima