Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No sound and CPU maxed with CC 64 sustain #676

Closed
jpcima opened this issue Mar 3, 2021 · 2 comments · Fixed by #723
Closed

No sound and CPU maxed with CC 64 sustain #676

jpcima opened this issue Mar 3, 2021 · 2 comments · Fixed by #723
Assignees
@paulfd
Labels
bug Something isn't working

Comments

@jpcima
Copy link
Collaborator

jpcima commented Mar 3, 2021

  • Send CC 64 value 127 to turn on sustain
  • Play some notes
  • Instrument goes silent
  • Voice count never decreases

Problem reproducible with NoBudgetBand guitar, eg. Guitar/LesPaul/lp_full.sfz
http://www.bandshed.net/sounds/sfz/nbb_guitars.zip
@kinwie
Copy link

kinwie commented Mar 3, 2021

@jpcima
I look at the file. There is an inappropriate placement of sw_lokey sw_hikey opcodes in the N1 file.
The sw_lokey=c2 sw_hikey=127 are placed at <group>
That might be causing the issue?

@kinwie
Copy link

kinwie commented Mar 3, 2021

Ooh wait. Guitar\LesPaul\lp_full.sfz played fine here

@paulfd paulfd self-assigned this Mar 4, 2021
@paulfd paulfd added the bug Something isn't working label Mar 9, 2021
@paulfd paulfd mentioned this issue Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulfd paulfd

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Free-run the envelope if the sustain value is low enough paulfd/sfizz
3 participants
@paulfd @jpcima @kinwie