-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Short audio files don't get played completely #916
Comments
There is some form of noise gate but it should not be active here. Thanks for the report ! |
This is possibly another case of the short sample being interpreted as a wavetable. |
Yes, that seems to be it! I added "oscillator=off" after the tag in several problematic .sfz drumkit files, and in all cases the swallowed or truncated samples now play correctly. So I guess it's an "intelligent" feature that one should be aware of. |
Ok, understood..thanks for digging this out. |
In the end I'm not sure that this feature does us a great service. |
Then again @jpcima sfizz could still support wavetables with The automatic setting to interpret all short samples as wavetables feels like a drag-n-drop feature anyway. So if a user drags a short sample onto sfizz, the generated sfz could set wavetable to on verbosely. But even then I think there are better ways to be clear as to the outcome for DnD. I'm not the biggest fan of magic behaviour, and this has always felt like it. |
In cakewalk dropzone, this definitely is a drag-and-drop feature. But we could use the audio size in frames. Wavetables will extremely likely be a power of 2. |
Honestly if this is confusing where I'd be more in favor of disabling the auto-detection entirely and let users decide to read the file as a wavetable. |
I'll put in a vote to disable the auto-detection. It caused me a lot of confusion at one point. |
Another possibility, it's |
For DnD function, why do we need auto? Could not the importer set the oscillator mode to |
it's what
|
I am creating a mapping for some drum kit library, and noticed that very short files don't get played out correctly. This happened under Linux, against JACK backend, using sfizz-git, branch "development", commit ID ce2170c.
I have attached a ZIP archive testdata.zip with an example .sfz and 3 short files of pink noise to show the effect.
The 0.2s and 0.1s duration files get played out correctly; the 0.05s file is only played partially.
This is also seen in the enclosed screenshot from a jack_capture run of that session.
Even though this might look like a "synthetic" test, there are in fact very short (hihat) samples that have roughly the same duration.
I assume this is not some kind of automatic "noise gate" kicking in?
If more info is needed, let me know. Thanks.
The text was updated successfully, but these errors were encountered: