Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Can we remove api-key authentication from the /health endpoint? #901

Closed
ucciicci opened this issue Aug 3, 2024 · 3 comments
Closed

Comments

@ucciicci
Copy link

ucciicci commented Aug 3, 2024

Motivation

Currently, when the server is started with an api-key, the /health endpoint also requires the api-key for requests.
Some cloud services' health check functions cannot set authentication information for requests, causing issues with deployment health checks.
Is it possible to remove the authentication check from the /health endpoint?

For reference, in vllm, the /health endpoint does not require authentication.

Related resources

No response

@zhyncs
Copy link
Member

zhyncs commented Aug 3, 2024

You may set ‘EMPTY’.

@ucciicci
Copy link
Author

ucciicci commented Aug 3, 2024

Thank you for your response.

What I would like to achieve is to have api-key authentication for inference endpoints (e.g., /v1/completions), but allow the /health endpoint to respond with a 200 status without requiring authentication.

@app.get("/health")

class APIKeyValidatorMiddleware(BaseHTTPMiddleware):

@Ying1123
Copy link
Member

Ying1123 commented Aug 4, 2024

Should be fixed by #917

@Ying1123 Ying1123 closed this as completed Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants