From 2634bc92c432cdf8556a30249552b9cc00d9d16c Mon Sep 17 00:00:00 2001 From: Joey Parrish Date: Thu, 28 Jan 2021 16:26:19 -0800 Subject: [PATCH] chore: Remove the term "blacklist" The term "blacklist" violates new Google guidelines about respectful language. This removes all instances of this term in our repo and replaces them with "denylist". Bug: 178203011 Change-Id: I90b19a2a8c5382bb36855c8f310b64e85c48c562 --- .eslintrc.js | 2 +- demo/load.js | 2 +- docs/design/offline.md | 17 ----------------- karma.conf.js | 2 +- 4 files changed, 3 insertions(+), 20 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index a4d4c507bc..f64c41a233 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -151,7 +151,7 @@ module.exports = { 'array-bracket-newline': ['error', 'consistent'], 'block-spacing': ['error', 'always'], 'brace-style': ['error', '1tbs', {'allowSingleLine': true}], - 'id-blacklist': ['error', 'async'], + 'id-denylist': ['error', 'async'], 'lines-between-class-members': 'error', 'max-statements-per-line': ['error', {'max': 1}], 'new-parens': 'error', diff --git a/demo/load.js b/demo/load.js index 2854c28feb..47b8157576 100644 --- a/demo/load.js +++ b/demo/load.js @@ -64,7 +64,7 @@ function shakaUncompiledModeSupported() { script.defer = true; // Setting async = false is important to make sure the script is imported // before the 'load' event fires. - script.async = false; // eslint-disable-line id-blacklist + script.async = false; // eslint-disable-line id-denylist document.head.appendChild(script); // Signal success, or else the Closure Library's loader will not load the diff --git a/docs/design/offline.md b/docs/design/offline.md index 8ec23704b8..6e6c3138bc 100644 --- a/docs/design/offline.md +++ b/docs/design/offline.md @@ -137,23 +137,6 @@ store a stream created by `StreamGenerator` and verify that the `StoredContent` structure is correct. A test should also load the stored data and verify that it matches the generated segments. -We should use a subset of IndexedDB supported by IE/Edge. Note the "partial -support" link on [caniuse]. Since the unsupported features seem to be about -key-based arrays and compound indexes, we should be able to easily avoid those. -Integration tests should help ensure that we are doing this correctly. - -Also note [caniuse]'s mention of bugs in Safari's IndexedDB implementation, -detailed in [this blog post]. It is not clear yet if the Safari bugs are on iOS -only or also on desktop. We may be forced to blacklist offline support as we -did with Safari 8 in `MediaSourceEngine.support()`. If the bugs have been fixed -in Safari 9 or don't affect desktop, we should be fine. If the bugs do affect -Safari 9 desktop, we could consider working around them. The workaround seems -to be to avoid autoincrement and to constructing string IDs for each object -which are unique across all object stores. - -[caniuse]: http://caniuse.com/#feat=indexeddb -[this blog post]: https://www.raymondcamden.com/2014/09/25/IndexedDB-on-iOS-8-Broken-Bad/ - #### Error conditions diff --git a/karma.conf.js b/karma.conf.js index 5554319586..023bab824f 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -382,7 +382,7 @@ function allUsableBrowserLaunchers(config) { // Most launchers requiring configuration through customLaunchers have // no DEFAULT_CMD. Some launchers have DEFAULT_CMD, but not for this // platform. Finally, WebDriver has DEFAULT_CMD, but still requires - // configuration, so we simply blacklist it by name. + // configuration, so we simply reject it by name. // eslint-disable-next-line no-restricted-syntax const DEFAULT_CMD = pluginConstructor.prototype.DEFAULT_CMD; if (!DEFAULT_CMD || !DEFAULT_CMD[process.platform]) {