From 6d1775a4312596dedbe41042b02564cbfc2381cf Mon Sep 17 00:00:00 2001 From: Alvaro Velad Galvan Date: Thu, 22 Jun 2023 13:04:55 +0200 Subject: [PATCH] Skip tests on Edge and Tizen --- lib/util/platform.js | 6 +++--- test/transmuxer/transmuxer_integration.js | 14 ++++++++++++++ 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/lib/util/platform.js b/lib/util/platform.js index 4eb5f6e47ec..3adf21ed54d 100644 --- a/lib/util/platform.js +++ b/lib/util/platform.js @@ -193,10 +193,10 @@ shaka.util.Platform = class { * @return {boolean} */ static isChrome() { - // The Edge user agent will also contain the "Chrome" keyword, so we need - // to make sure this is not Edge. + // The Edge Legacy user agent will also contain the "Chrome" keyword, so we + // need to make sure this is not Edge Legacy. return shaka.util.Platform.userAgentContains_('Chrome') && - !shaka.util.Platform.isEdge(); + !shaka.util.Platform.isLegacyEdge(); } /** diff --git a/test/transmuxer/transmuxer_integration.js b/test/transmuxer/transmuxer_integration.js index a17ea9bdea2..8e1352bae77 100644 --- a/test/transmuxer/transmuxer_integration.js +++ b/test/transmuxer/transmuxer_integration.js @@ -111,6 +111,20 @@ describe('Transmuxer Player', () => { if (!MediaSource.isTypeSupported('audio/mp4; codecs="ac-3"')) { return; } + // This tests is flaky in some Tizen devices, so we need omit it for now. + if (shaka.util.Platform.isTizen()) { + return; + } + // It seems that AC3 on Edge Windows from github actions is not working + // (in the lab AC3 is working). The AC3 detection is currently hard-coded + // to true, which leads to a failure in GitHub's environment. + // We must enable this, once it is resolved: + // https://bugs.chromium.org/p/chromium/issues/detail?id=1450313 + if (shaka.util.Platform.isEdge() && + shaka.util.Platform.chromeVersion() <= 116) { + return; + } + // eslint-disable-next-line max-len const url = 'https://devstreaming-cdn.apple.com/videos/streaming/examples/img_bipbop_adv_example_ts/a2/prog_index.m3u8';