From 7c18e08a42ced1070fcb02c5b6787d1cfff392a8 Mon Sep 17 00:00:00 2001 From: Niklas Korz Date: Thu, 1 Feb 2018 17:04:00 +0100 Subject: [PATCH] Rename Timeline events to include the "Event" suffix (#1267) Right now, the timeline related events are the only events defined without an "Event"-suffix in the name. Their naming should follow the naming used throughout the rest of the project. --- AUTHORS | 1 + CONTRIBUTORS | 1 + lib/player.js | 6 +++--- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/AUTHORS b/AUTHORS index 3d02f83be7..1449e60fc3 100644 --- a/AUTHORS +++ b/AUTHORS @@ -14,6 +14,7 @@ # Please keep the list sorted. AdsWizz <*@adswizz.com> +Alugha GmbH <*@alugha.com> Bonnier Broadcasting <*@bonnierbroadcasting.com> Bryan Huh Esteban Dosztal diff --git a/CONTRIBUTORS b/CONTRIBUTORS index ca819d95bc..0765233da3 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -51,6 +51,7 @@ Mattias Wadman Michelle Zhuo Natalie Harris Nick Desaulniers +Niklas Korz Oskar Arvidsson Robert Colantuoni Rohit Makasana diff --git a/lib/player.js b/lib/player.js index 5b654d675e..704b63cfe7 100644 --- a/lib/player.js +++ b/lib/player.js @@ -289,7 +289,7 @@ shaka.Player.version = 'v2.3.0-uncompiled'; /** - * @event shaka.Player.TimelineRegionAdded + * @event shaka.Player.TimelineRegionAddedEvent * @description Fired when a media timeline region is added. * @property {string} type * 'timelineregionadded' @@ -300,7 +300,7 @@ shaka.Player.version = 'v2.3.0-uncompiled'; /** - * @event shaka.Player.TimelineRegionEnter + * @event shaka.Player.TimelineRegionEnterEvent * @description Fired when the playhead enters a timeline region. * @property {string} type * 'timelineregionenter' @@ -311,7 +311,7 @@ shaka.Player.version = 'v2.3.0-uncompiled'; /** - * @event shaka.Player.TimelineRegionExit + * @event shaka.Player.TimelineRegionExitEvent * @description Fired when the playhead exits a timeline region. * @property {string} type * 'timelineregionexit'