From 88a771087d0785345c0c1bc3f5407ebd404100a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lvaro=20Velad=20Galv=C3=A1n?= Date: Wed, 19 Apr 2023 19:14:55 +0200 Subject: [PATCH] fix: Fix handling of CC when switching between codecs (#5160) --- lib/media/media_source_engine.js | 3 ++- lib/text/text_engine.js | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/media/media_source_engine.js b/lib/media/media_source_engine.js index bd7d8b36d37..2c3e703c9de 100644 --- a/lib/media/media_source_engine.js +++ b/lib/media/media_source_engine.js @@ -587,7 +587,8 @@ shaka.media.MediaSourceEngine = class { data = transmuxedData.data; } else if (hasClosedCaptions) { if (!this.textEngine_) { - this.reinitText('text/vtt', this.sequenceMode_); + this.reinitText(shaka.util.MimeUtils.CEA608_CLOSED_CAPTION_MIMETYPE, + this.sequenceMode_); } // If it is the init segment for closed captions, initialize the closed // caption parser. diff --git a/lib/text/text_engine.js b/lib/text/text_engine.js index 0deebeea5ef..f4a53b50277 100644 --- a/lib/text/text_engine.js +++ b/lib/text/text_engine.js @@ -139,6 +139,7 @@ shaka.text.TextEngine = class { // into TextEngine and TextDisplayer. if (mimeType == shaka.util.MimeUtils.CEA608_CLOSED_CAPTION_MIMETYPE || mimeType == shaka.util.MimeUtils.CEA708_CLOSED_CAPTION_MIMETYPE) { + this.parser_ = null; return; }