-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for comments on leap second handling #1242
Comments
@joeyparrish could you take a look at this? |
@sandersaares, that all looks fine to me. Realistically, we are not going to implement a leap-second-aware clock, though. The whole thing is predicated on the use of availabilityStartTime to compute the perfect presentation timeline. But we already can't count on availabilityStartTime because of encoder drift. See #999. Ultimately, we will ignore availabilityStartTime for all but SegmentTemplate+duration manifests. |
Thanks for taking a look! Glad to hear there was nothing surprising in there. Do I understand it right from your comment about leap-second-aware clock that whatever browser based timing mechanism is used by Shaka is not leap second aware? That is to say, when Shaka currently adds a |
We use In your example, we compare the results of |
For what it's worth, EME's definition of time is at https://w3c.github.io/encrypted-media/#time. It defers to ECMAScript Date Objects where "In time values leap seconds are ignored." |
It does indeed look like I will close this now as comments were received and questions answered. Thanks! |
DASH-IF has published document for community review.
LEAP SECOND HANDLING CLARIFICATIONS
It would be very desirable to hear some feedback from player developers on this topic!
The text was updated successfully, but these errors were encountered: