Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing audio cause video buffer clear. #1714

Closed
avelad opened this issue Nov 30, 2018 · 3 comments
Closed

Changing audio cause video buffer clear. #1714

avelad opened this issue Nov 30, 2018 · 3 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@avelad
Copy link
Member

avelad commented Nov 30, 2018

Have you read the FAQ and checked for duplicate open issues?: Yes

What version of Shaka Player are you using?: 2.5.0-beta2

Can you reproduce the issue with our latest release version?: Yes

Can you reproduce the issue with the latest code from master?: Yes

Are you using the demo app or your own custom app?: Both

If custom app, can you reproduce the issue using our demo app?: Yes

What browser and OS are you using?:
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.77 Safari/537.36 (Chrome 70 - Ubuntu 18.04)

What are the manifest and license server URIs?:
https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd

What did you do?
Load the stream. Observe Buffer Info with getBufferedInfo(), change the audio language

What did you expect to happen?
Only audio buffer is cleared. We only change the audio not the resolution.

What actually happened?
Audio and Video buffer are cleared

@TheModMaker
Copy link
Contributor

How are you changing the audio language? Are you using selectAudioLanguage or selectVariantTrack?

I'm fairly sure it should work with selectVariantTrack, but if you are using selectAudioLanguage, it may not because of how we switch streams. My guess would be that you do this early and ABR hasn't stabilized yet, so when we select a new track with the new preference, ABR selects a different video stream and so we clear the buffer.

@avelad
Copy link
Member Author

avelad commented Nov 30, 2018

I’m using selectVariantTrack

@TheModMaker
Copy link
Contributor

It looks like when we clear the audio buffer, it triggers a seek to flush the media. Because the audio buffer is empty, it is considered an unbuffered seek and we clear everything. We shouldn't be doing this.

@TheModMaker TheModMaker added type: bug Something isn't working correctly and removed needs triage labels Nov 30, 2018
@TheModMaker TheModMaker added this to the v2.5 milestone Nov 30, 2018
@theodab theodab self-assigned this Jan 17, 2019
@joeyparrish joeyparrish self-assigned this Apr 18, 2019
@shaka-project shaka-project locked and limited conversation to collaborators Jul 7, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

6 participants