Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.5.0-beta3 compiled release reports v2.5.0-beta3-uncompiled #1816

Closed
avelad opened this issue Feb 21, 2019 · 2 comments
Closed

Version 2.5.0-beta3 compiled release reports v2.5.0-beta3-uncompiled #1816

avelad opened this issue Feb 21, 2019 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@avelad
Copy link
Member

avelad commented Feb 21, 2019

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
2.5.0-beta3

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
No tested

Are you using the demo app or your own custom app?
Demo app

If custom app, can you reproduce the issue using our demo app?
Demo app

What browser and OS are you using?
Chrome 72 / Ubuntu 18.04

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What did you do?

Open https://v2-5-0-beta3-dot-shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd;lang=es-ES;build=compiled

What did you expect to happen?
The header reports Shaka Player v2.5.0-beta3

What actually happened?

The header reports Shaka Player v2.5.0-beta3-uncompiled

With v2.4.7 works correctly https://v2-4-7-dot-shaka-player-demo.appspot.com/demo/#asset=https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd;lang=es-ES;build=compiled

@joeyparrish
Copy link
Member

You are correct! Thank you for pointing this out.

I compared the results on appspot with a local build. The effect is seen locally, so it's not an issue with our deployment process.

@joeyparrish joeyparrish self-assigned this Feb 21, 2019
@joeyparrish joeyparrish added type: bug Something isn't working correctly and removed needs triage labels Feb 21, 2019
@joeyparrish joeyparrish added this to the v2.5 milestone Feb 21, 2019
@joeyparrish
Copy link
Member

Our build script had a regression in 6b1ca2d, which was a complicated merge from a private branch. It should be easy to fix.

@shaka-project shaka-project locked and limited conversation to collaborators Apr 22, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants