Disable PiP button when playing audio-only assets #1849
Labels
component: UI
The issue involves the Shaka Player UI
flag: good first issue
This might be a relatively easy issue; good for new contributors
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
When playing an audio-only asset, the Picture-in-Picture button on the UI shows up. Pressing the button, however, results in an error.
If the button doesn't work, we should just not show it.
Similarly, there are issues if you enter PiP mode while playing a valid asset, and then load an audio-only asset. The PiP window will stay open, and the player will continue to be greyed out, but the audio-only asset will be playing, and the PiP window and the player will no longer be presenting the same asset. We should probably leave PiP mode automatically, in that case.
The text was updated successfully, but these errors were encountered: