Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VTT subtitles synchronization for live HLS #1968

Closed
Romain-Bernier opened this issue May 28, 2019 · 3 comments
Closed

VTT subtitles synchronization for live HLS #1968

Romain-Bernier opened this issue May 28, 2019 · 3 comments
Assignees
@TheModMaker
Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue type: question A question from the community

Comments

@Romain-Bernier
Copy link

In my company we generate VTT subtitles with absolute timestamps,
To make it work on shaka, I have to modified the
let offset = time.segmentStart; to let offset = 0;
in the vtt_text_parser.js
Other player like hls.js or Exoplayer work find with absolute timestamps.
have you planned to support absolute timestamps, and if not, why ?
@Romain-Bernier Romain-Bernier added the type: question A question from the community label May 28, 2019
@TheModMaker
Copy link
Contributor

See #1563.

@TheModMaker TheModMaker added the status: duplicate A duplicate of another issue; should be closed after linking to the original issue label May 28, 2019
@shaka-bot
Copy link
Collaborator

@Romain-Bernier Does this answer all your questions? Can we close the issue?

@shaka-bot shaka-bot added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jun 1, 2019
@Romain-Bernier
Copy link
Author

Yes, I hope you will find time to fix this in the v2.6.
This mean support of empty VTT segment and absolute timestamps support for live HLS.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Jun 3, 2019
@shaka-project shaka-project locked and limited conversation to collaborators Aug 2, 2019
@TheModMaker TheModMaker self-assigned this Feb 27, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TheModMaker TheModMaker

Labels
status: archived Archived and locked; will not be updated status: duplicate A duplicate of another issue; should be closed after linking to the original issue type: question A question from the community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheModMaker @shaka-bot @Romain-Bernier