Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant calls being made to HLS child manifest #2066

Closed
thecuriousdev opened this issue Jul 31, 2019 · 4 comments
Closed

Redundant calls being made to HLS child manifest #2066

thecuriousdev opened this issue Jul 31, 2019 · 4 comments
Assignees
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: performance A performance issue
Milestone

Comments

@thecuriousdev
Copy link

thecuriousdev commented Jul 31, 2019

Have you read the FAQ and checked for duplicate open issues?
YES

What version of Shaka Player are you using?
2.5.4

Can you reproduce the issue with our latest release version?
YES

Can you reproduce the issue with the latest code from master?
YES

Are you using the demo app or your own custom app?
Demo App

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Chrome 78, MacOS

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?
https://shaka-player-demo.appspot.com/demo/#audiolang=en-GB;textlang=en-GB;uilang=en-GB;asset=https://storage.googleapis.com/shaka-demo-assets/angel-one-hls/hls.m3u8;panel=SEARCH;build=uncompiled

What did you do?

Redundant calls being made to child manifest

What did you expect to happen?
We only need to fetch a specific manifest only once instead, we can observe multiple calls. And increasing the video's start lag.

What actually happened?
Check the network tab, and search for playlist_a-eng-0128k-aac-2c.mp4.m3u8 you can see that a total of 5 calls being made to the same child manifest.

@ismena ismena added the type: performance A performance issue label Jul 31, 2019
@joeyparrish joeyparrish added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format and removed needs triage labels Jul 31, 2019
@joeyparrish
Copy link
Member

You are correct, we shouldn't have to fetch the audio playlist 5 times during startup. Thanks for the report!

@shaka-bot shaka-bot added this to the v2.6 milestone Jul 31, 2019
@thecuriousdev
Copy link
Author

Thanks for the response, also what is the ETA for v2.6?

@joeyparrish
Copy link
Member

v2.6 is blocked on #1339 and a number of bugs. This is marked "bug", so we will try to cherry-pick the fix to v2.5.x. You won't have to wait for v2.6 to get this fixed.

@michellezhuogg
Copy link
Contributor

This should be fixed with Hls refactor soon.

@michellezhuogg michellezhuogg self-assigned this Aug 4, 2019
@shaka-project shaka-project locked and limited conversation to collaborators Oct 6, 2019
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: performance A performance issue
Projects
None yet
Development

No branches or pull requests

5 participants