Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to ignore a segment and buffer next segment? #2144

Closed
thinhvnu opened this issue Sep 13, 2019 · 13 comments
Closed

How to ignore a segment and buffer next segment? #2144

thinhvnu opened this issue Sep 13, 2019 · 13 comments
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request

Comments

@thinhvnu
Copy link

thinhvnu commented Sep 13, 2019

Dear shaka team,
I want to play chunk 1.ts, ignore 2.ts if it has error and buffers 3.ts without seeking to 3.ts
Our case is chunk error 404 not found. Player retry 2 times and stuck. I want to ignore this and get next
Screenshot from 2019-09-13 16-12-20

Pls help

@thinhvnu thinhvnu added the type: question A question from the community label Sep 13, 2019
@theodab
Copy link
Contributor

theodab commented Sep 13, 2019

Could you please fill out the bug report template? You have not provided enough information for us to do anything.

@theodab theodab closed this as completed Sep 13, 2019
@ismena
Copy link
Contributor

ismena commented Sep 13, 2019

Oh, I don't think that's a bug report!

@thinhnv789 please correct me if I'm wrong, here's I thought the issue was about:
One of the segments in a stream fails to be downloaded and you want the player to try and go to the next one instead of stopping and throwing an error.
Is that right?

Is that for a live stream? I think I remember @joeyparrish telling me that this happened with live streams sometimes. Or was it you, Jacob? @TheModMaker
Can we treat it as a gap or something?

@ismena ismena reopened this Sep 13, 2019
@ismena
Copy link
Contributor

ismena commented Sep 13, 2019

@thinhnv789 Could you please still fill out the template that @theodab linked to, so we have all the info to look at your use case? You can do it here, or close this one and file a separate issue.

Sorry, I single-handedly re-opened this, @theodab

@ismena
Copy link
Contributor

ismena commented Sep 13, 2019

Update: we don't have capability to skip failed segments at the moment, but this sounds like something we should be able to add without too much trouble since we already have gap-jumping capabilities.

I'll tag this an enhancement.

@ismena ismena added type: enhancement New feature or request and removed type: question A question from the community labels Sep 13, 2019
@shaka-bot shaka-bot added this to the Backlog milestone Sep 13, 2019
@thinhvnu
Copy link
Author

@ismena thank for your support,
You understand what I mean,
One of the segments in a stream fails to be downloaded and you want the player to try and go to the next one instead of stopping and throwing an error.
please let do it if you can.
Thanks,

@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@caridley
Copy link
Contributor

caridley commented Mar 2, 2021

We see this situation fairly frequently in some or our live streams. We currently recover by restarting the player which isn't the best experience.

@ismena
Copy link
Contributor

ismena commented Mar 2, 2021

@caridley I hear you.
I think, we had some gap jumping work planned for v4, maybe this can be part of that.
Let me bring it up with the team. If not, maybe we could accept a PR for this.
@joeyparrish thoughts?

@joeyparrish
Copy link
Member

I think we could add a config option for it. If set, StreamingEngine could move on to the next segment if a segment request fails. I feel certain it should be used only for live streams, but I'm not sure if that would be best enforced or just documented for that option, and left to applications to decide. I think I would lean toward giving app developers the choice. It probably wouldn't actually hurt to turn it on for VOD.

@avelad
Copy link
Member

avelad commented Mar 3, 2021

In my opinion:
In Live streams we should always try to reproduce, skip gaps and even erroneous segments. What the user wants is to play the Live stream, in DVB this is always the case, so in adaptive streaming it should be the same.

Note: there is sometimes that there is the catchup/startover/retrogrid/... option that uses a circular buffer of N days and in the end the playlist is VoD, so here it would also make sense.

@ismena
Copy link
Contributor

ismena commented Mar 3, 2021

@joeyparrish Are we open on PRs on this with our current gap jumping logic or does it not make sense until that's changed?

@rahulkrish
Copy link

@joeyparrish @ismena Any updates on this issue? Are you open to PRs with the current gap jumping logic or is this going to be addressed as part of v4?

@joeyparrish
Copy link
Member

We are open to PRs, with a preference to discuss the concept of your change here before reviewing a PR, to help make sure we're in agreement. Any breaking change will be deferred to v4 (or accelerate our decision to bump the version number to v4, if it's really compelling).

@avelad
Copy link
Member

avelad commented Jul 22, 2024

Solved by #4189

@avelad avelad closed this as completed Jul 22, 2024
@avelad avelad removed this from the Backlog milestone Jul 22, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 20, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants