Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong pixelAspectRatio population in DASH #2611

Closed
avelad opened this issue Jun 2, 2020 · 1 comment
Closed

Wrong pixelAspectRatio population in DASH #2611

avelad opened this issue Jun 2, 2020 · 1 comment
Assignees
@avelad
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.0

Comments

@avelad
Copy link
Member

avelad commented Jun 2, 2020 •
edited
Loading

The current implementation of pixelAspectRatio in DASH is wrong. @par in DASH is "display aspect ratio" so the correct is populate this field with @sar

Note: Tomorrow, I'll send a PR for this.
@joeyparrish joeyparrish added type: enhancement New feature or request and removed needs triage labels Jun 2, 2020
@shaka-bot shaka-bot added this to the Backlog milestone Jun 2, 2020
@avelad avelad mentioned this issue Jun 3, 2020
Merged
@avelad avelad changed the title Expose Storage Aspect Ratio (SAR) in shaka.extern.Stream Wrong pixelAspectRatio population in DASH Jun 3, 2020
@joeyparrish joeyparrish modified the milestones: Backlog, v3.0 Jun 3, 2020
@joeyparrish joeyparrish added type: bug Something isn't working correctly and removed type: enhancement New feature or request labels Jun 3, 2020
@joeyparrish
Copy link
Member

Fixed in 1568d28, but we did not tag the issue in the PR when we merged it.

@shaka-project shaka-project locked and limited conversation to collaborators Aug 2, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@avelad avelad

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
3 participants
@joeyparrish @avelad @shaka-bot