Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shaka 2.5 is not raising DASH manifest timed metadata during period boundaries #2723

Closed
TheSouryaRoy opened this issue Jul 13, 2020 · 3 comments
Assignees
Labels
status: archived Archived and locked; will not be updated

Comments

@TheSouryaRoy
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
2.5

Can you reproduce the issue with our latest release version?
Not reproducible in Shaka 3.0.1

Are you using the demo app or your own custom app?
Own custom app (link below)

If custom app, can you reproduce the issue using our demo app?
Could not extract timed metadata from the demo app

What browser and OS are you using?
Chrome 83, MacOS 10.15.5

What issue are you facing?
We are playing a DAI stream on Shaka Player 2.5 with IMA SDK. This is a multi-period manifest with one ad in each period. During period boundaries (i.e. transition from current ad to next ad), we are observing that the first timed metadata event of the next period, or the last event of the current period fails to get raised.

This issue happens 50-60% of the time.

We tried to reproduce the issue on Shaka 3.0.1, but were unsuccessful.

What did you do?

  1. Went to demo app: https://storage.googleapis.com/gvabox/sanils/h5/dai/shaka_test/dai_shaka.html
  2. Entered 0ndl1dJcRmKDUPxTRjvdog on the Asset Key field, if not already filled
  3. Hit "Request Live"
  4. Wait a few minutes if the issue is does not happen at the get go (we are able to observe the issue 50-60% of the time)

The timed metadata raised by Shaka player is shown in the console log. We compare that with the timed metadata events in the manifest file.

For reference, here is the manifest link: https://dai.google.com/linear/dash/pa/event/0ndl1dJcRmKDUPxTRjvdog/stream/24aa41be-f95c-4cb8-aab8-a73d1f717a59:ATL/manifest.mpd

What did you expect to happen?
All timed metadata events in the manifest are raised.

What actually happened?
During period boundaries, the last timed metadata of the current period or the first timed metadata of the next period is not raised.

Additional screenshots & logs
Sent to [email protected]

@ismena
Copy link
Contributor

ismena commented Jul 15, 2020

@TheSouryaRoy
We generally don't work on issues that manifest in previous releases, but not the latest one, and encourage people to upgrade to the latest release instead. I understand that v3.0.1 also needs attention in terms of DASH event reporting, and we're in the process of looking into those.

Is that why you've gone back to using v2.5 or are there other reasons for it?

@TheSouryaRoy
Copy link
Author

@ismena the reason we are exploring 2.5 is due to the issue in 3.0.1. If we can get 3.0.1 fixed, it should be fine for us. Thanks!

@ismena
Copy link
Contributor

ismena commented Jul 16, 2020

v3 is what the majority of users are gonna go with, so let us give fixing it our best shot before considering alternatives.
#2716 might take a bit of time to figure out due to its inconsistency and the length of the repro cycle, but we are committed to trying to get to the bottom of it, and there are still things we can look at to track it down.

I'm gonna close this issue for now. Let's get back to it in case we're completely at a dead end with #2716

@ismena ismena closed this as completed Jul 16, 2020
@shaka-project shaka-project locked and limited conversation to collaborators Sep 14, 2020
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

No branches or pull requests

3 participants