Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error is not instance of shaka.util.Error #370

Closed
aletorrado opened this issue May 6, 2016 · 5 comments
Closed

Error is not instance of shaka.util.Error #370

aletorrado opened this issue May 6, 2016 · 5 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@aletorrado
Copy link

This code is triggering an assert of this type:

  this.requestManifest_().then(function() {
    // Detect a call to stop()
    if (!this.networkingEngine_)
      return;

    // Ensure the next update occurs within |updatePeriod_| seconds by taking
    // into account the time it took to update the manifest.
    var endTime = Date.now();
    this.setUpdateTimer_((endTime - startTime) / 1000.0);
  }.bind(this)).catch(function(error) {
    goog.asserts.assert(error instanceof shaka.util.Error,
                        'Should only receive a Shaka error');

Don't know what the error is for (nothing gets printed), but here is the manifest:

<?xml version="1.0" encoding="utf-8"?>
<MPD xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xmlns="urn:mpeg:dash:schema:mpd:2011"
    xmlns:xlink="http://www.w3.org/1999/xlink"
    xsi:schemaLocation="urn:mpeg:DASH:schema:MPD:2011 http://standards.iso.org/ittf/PubliclyAvailableStandards/MPEG-DASH_schema_files/DASH-MPD.xsd"
    profiles="urn:mpeg:dash:profile:isoff-live:2011"
    type="dynamic"
    minimumUpdatePeriod="PT4S"
    suggestedPresentationDelay="PT4S"
    availabilityStartTime="2016-05-05T20:02:46"
    publishTime="2016-05-06T00:02:10"
    minBufferTime="PT4.1S">
    <ProgramInformation>
    </ProgramInformation>
    <Period start="PT0.0S">
        <AdaptationSet contentType="video" segmentAlignment="true" bitstreamSwitching="true" frameRate="30/1">
            <Representation id="0" mimeType="video/mp4" codecs="avc1.64001f" bandwidth="1200000" width="854" height="480" frameRate="30/1">
                <SegmentTemplate timescale="15360" initialization="init-stream$RepresentationID$.m4s" media="chunk-stream$RepresentationID$-$Number%05d$.m4s" startNumber="1">
                    <SegmentTimeline>
                        <S t="0" d="64000" r="1" />
                        <S d="27136" />
                        <!-- thousands of segments more -->
                    </SegmentTimeline>
                </SegmentTemplate>
            </Representation>
            <Representation id="1" mimeType="video/mp4" codecs="avc1.64001f" bandwidth="2400000" width="1280" height="720" frameRate="30/1">
                <SegmentTemplate timescale="15360" initialization="init-stream$RepresentationID$.m4s" media="chunk-stream$RepresentationID$-$Number%05d$.m4s" startNumber="1">
                    <SegmentTimeline>
                        <S t="0" d="64000" />
                        <S d="62464" />
                        <!-- thousands of segments more -->
                    </SegmentTimeline>
                </SegmentTemplate>
            </Representation>
        </AdaptationSet>
        <AdaptationSet contentType="audio" segmentAlignment="true" bitstreamSwitching="true">
            <Representation id="2" mimeType="audio/mp4" codecs="mp4a.40.2" bandwidth="96000" audioSamplingRate="44100">
                <AudioChannelConfiguration schemeIdUri="urn:mpeg:dash:23003:3:audio_channel_configuration:2011" value="2" />
                <SegmentTemplate timescale="44100" initialization="init-stream$RepresentationID$.m4s" media="chunk-stream$RepresentationID$-$Number%05d$.m4s" startNumber="1">
                    <SegmentTimeline>
                        <S t="0" d="181248" />
                        <S d="179200" />
                        <!-- thousands of segments more -->
                    </SegmentTimeline>
                </SegmentTemplate>
            </Representation>
        </AdaptationSet>
    </Period>
</MPD>

Maybe it's the MPD size? (> 6000 segments)

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label May 6, 2016
@joeyparrish joeyparrish added this to the v2.0.0 milestone May 6, 2016
@joeyparrish
Copy link
Member

You should only see instances of shaka.util.Error at the application level. The assertion means that there is a condition we are not handling properly. Otherwise, the assertion itself is harmless. There is, however, an error condition of some kind. Since we are not reporting it correctly, it's hard to say what it is. :-)

If you can provide a manifest URL, we can try it out and trace the real problem for you.

@aletorrado
Copy link
Author

aletorrado commented May 6, 2016

I cannot publish it yet, but I've just verified that error===undefined. It's strange.

@tdrews
Copy link
Contributor

tdrews commented May 10, 2016

Thanks for the report. I can reproduce this issue. We'll take a look. Maybe related #369?

@tdrews tdrews self-assigned this May 10, 2016
@tdrews
Copy link
Contributor

tdrews commented May 23, 2016

Hi, since be09f52 I no longer see this problem as before. Are you still seeing this error from master?

@tdrews
Copy link
Contributor

tdrews commented Jun 3, 2016

This seems to have been fixed by be09f52.

@tdrews tdrews closed this as completed Jun 3, 2016
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants