-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove IE 11 from default browsers for Windows (#4271) #4272
fix: Remove IE 11 from default browsers for Windows (#4271) #4272
Conversation
IE 11 has not been supported since v3.1, so developers following CONTRIBUTING.md should not see tests fail due to the continued inclusion of IE. Removed IE from the default list of browsers for Windows. Anybody who still needs to test against IE can explicitly test via python build/test.py --browsers IE.
Is there a way to re-run the failed check? The failure in Build and Test PR / macos-latest Firefox (pull request): "stores, plays, and deletes protected content with a temporary license [Firefox 100.0 (Mac OS 10.15)]", appears to be a transient issue, "Error: Timeout waiting for movement from 0 to 3". When I locally run python3 build/test.py --browsers Firefox --filter=stores I get 12 passing tests. This is against both Firefox 100.0 and an older Intel/Catalina and Firefox 101.0 M1/Monterey. |
Yeah, we can trigger the "Build and Test PR" action manually. Well, whatever. It's obvious that this PR isn't the cause of that failed test, so it should be fine to merge. |
IE 11 has not been supported since v3.1, so developers following CONTRIBUTING.md should not see tests fail due to the continued inclusion of IE. Removed IE from the default list of browsers for Windows. Anybody who still needs to test against IE can explicitly test via python build/test.py --browsers IE. Closes shaka-project#4271
IE 11 has not been supported since v3.1, so developers following CONTRIBUTING.md should not see tests fail due to the continued inclusion of IE. Removed IE from the default list of browsers for Windows. Anybody who still needs to test against IE can explicitly test via python build/test.py --browsers IE. Closes #4271
IE 11 has not been supported since v3.1, so developers following CONTRIBUTING.md should not see tests fail due to the continued inclusion of IE. Removed IE from the default list of browsers for Windows. Anybody who still needs to test against IE can explicitly test via python build/test.py --browsers IE. Closes #4271
IE 11 has not been supported since v3.1, so developers following CONTRIBUTING.md should not see tests fail due to the continued inclusion of IE. Removed IE from the default list of browsers for Windows. Anybody who still needs to test against IE can explicitly test via python build/test.py --browsers IE. Closes #4271
IE 11 has not been supported since v3.1, so developers following CONTRIBUTING.md should not see tests fail due to the continued inclusion of IE. Removed IE from the default list of browsers for Windows. Anybody who still needs to test against IE can explicitly test via python build/test.py --browsers IE. Closes #4271
IE 11 has not been supported since v3.1, so developers following
CONTRIBUTING.md should not see tests fail due to the continued inclusion
of IE. Removed IE from the default list of browsers for Windows. Anybody
who still needs to test against IE can explicitly test via python
build/test.py --browsers IE.