Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove IE 11 from default browsers for Windows (#4271) #4272

Conversation

RaymondCheng
Copy link
Contributor

IE 11 has not been supported since v3.1, so developers following
CONTRIBUTING.md should not see tests fail due to the continued inclusion
of IE. Removed IE from the default list of browsers for Windows. Anybody
who still needs to test against IE can explicitly test via python
build/test.py --browsers IE.

IE 11 has not been supported since v3.1, so developers following
CONTRIBUTING.md should not see tests fail due to the continued inclusion
of IE. Removed IE from the default list of browsers for Windows. Anybody
who still needs to test against IE can explicitly test via python
build/test.py --browsers IE.
@avelad avelad added the type: bug Something isn't working correctly label Jun 3, 2022
@avelad avelad added this to the v4.2 milestone Jun 3, 2022
@avelad avelad added platform: Windows Issues affecting Windows component: tests The issue involves our automated tests (generally; otherwise use a more specific component) labels Jun 3, 2022
@avelad avelad linked an issue Jun 3, 2022 that may be closed by this pull request
@RaymondCheng
Copy link
Contributor Author

Is there a way to re-run the failed check? The failure in Build and Test PR / macos-latest Firefox (pull request): "stores, plays, and deletes protected content with a temporary license [Firefox 100.0 (Mac OS 10.15)]", appears to be a transient issue, "Error: Timeout waiting for movement from 0 to 3". When I locally run python3 build/test.py --browsers Firefox --filter=stores I get 12 passing tests. This is against both Firefox 100.0 and an older Intel/Catalina and Firefox 101.0 M1/Monterey.

@theodab
Copy link
Contributor

theodab commented Jun 4, 2022

Yeah, we can trigger the "Build and Test PR" action manually.
...I just did it twice and it failed to fetch the repo twice. Might be something up with the Github servers or something?

Well, whatever. It's obvious that this PR isn't the cause of that failed test, so it should be fine to merge.

@theodab theodab merged commit 490b06c into shaka-project:main Jun 4, 2022
avelad pushed a commit to avelad/shaka-player that referenced this pull request Jun 8, 2022
IE 11 has not been supported since v3.1, so developers following
CONTRIBUTING.md should not see tests fail due to the continued inclusion
of IE. Removed IE from the default list of browsers for Windows. Anybody
who still needs to test against IE can explicitly test via python
build/test.py --browsers IE.

Closes shaka-project#4271
avelad pushed a commit that referenced this pull request Jun 14, 2022
IE 11 has not been supported since v3.1, so developers following
CONTRIBUTING.md should not see tests fail due to the continued inclusion
of IE. Removed IE from the default list of browsers for Windows. Anybody
who still needs to test against IE can explicitly test via python
build/test.py --browsers IE.

Closes #4271
avelad pushed a commit that referenced this pull request Jun 14, 2022
IE 11 has not been supported since v3.1, so developers following
CONTRIBUTING.md should not see tests fail due to the continued inclusion
of IE. Removed IE from the default list of browsers for Windows. Anybody
who still needs to test against IE can explicitly test via python
build/test.py --browsers IE.

Closes #4271
avelad pushed a commit that referenced this pull request Jun 14, 2022
IE 11 has not been supported since v3.1, so developers following
CONTRIBUTING.md should not see tests fail due to the continued inclusion
of IE. Removed IE from the default list of browsers for Windows. Anybody
who still needs to test against IE can explicitly test via python
build/test.py --browsers IE.

Closes #4271
joeyparrish pushed a commit that referenced this pull request Jun 14, 2022
IE 11 has not been supported since v3.1, so developers following
CONTRIBUTING.md should not see tests fail due to the continued inclusion
of IE. Removed IE from the default list of browsers for Windows. Anybody
who still needs to test against IE can explicitly test via python
build/test.py --browsers IE.

Closes #4271
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: tests The issue involves our automated tests (generally; otherwise use a more specific component) platform: Windows Issues affecting Windows status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove IE 11 from default browsers list
3 participants