-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLS AES-128 streams fail to play in MS Edge and when casting #4441
Comments
I was able to reproduce it in Edge. There must be some bug in the AES-128 implementation. @theodab you have implemented it, can you take a look at it? |
MS Edge has native transmuxing of mpeg-2-ts chunks of hls streams. <script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/mux.js"></script> in the head of your app or project. ...And also make sure you have player.configure("streaming.forceTransmuxTS", true); inside your init function. async function init() { player.configure("streaming.forceTransmuxTS", true); } Make sure to report this error to MS so you don't have to include this all in future. |
This was how I fixed it as I also use MS edge. https://www.speedynet.eu.org/shaka?link=<YOUR_MANIFEST_URL> This is a quick way of testing HLS streams on Edge with Shaka player. |
We just pushed Shaka 4.2.0 to production and started seeing this issue in MS Edge.
We'll test the |
I would guess that errors relating to I'm confused by some of the posts. The OP says the issue starts when casting, but others are suggesting fixes that relate to Edge playback rather than Chromecast playback. Does the issue occur only when casting? Or does the issue occur when playing directly in Edge? Does the issue occur when casting from other browsers, such as Chrome? |
Both. The problem occurs with direct playback from Edge - and also when initiating a cast session from any browser, including Edge. When I add the forceTransmuxTS workaround to the player setup in Edge, direct playback works fine. But when attempting to cast the player throws that same error message: CastSender: onSessionInitiated
|
@theodab can you review this issue? Thanks! |
I tried this out in MS Edge and didn't see the error. I un-applied #4543 (which looks like it is describing the same issue) and tried again and did see the error, so I think this is fixed now. |
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.2 nightly
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Have not tried
Are you using the demo app or your own custom app?
The Shaka demo app
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
Microsoft Edge
Chromecast from Google Chrome on Windows and Ubuntu
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
I've been testing with "Art of Motion (HLS, TS, AES-128)" on the Shaka demo page
What configuration are you using? What is the output of
player.getConfiguration()
?The config is as configured on the demo page
What did you do?
Test 1: Navigate to the stream in MS Edge and start playback
Test 2: Navigate to the stream in Chrome and start casting
What did you expect to happen?
The video to play without issues
What actually happened?
In both cases, the video starts playing but after a couple of seconds playback stops with the following error:
The text was updated successfully, but these errors were encountered: