Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cea): Fix MAX_ROWS in CEA-708 window #4757

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 24, 2022

Fixes #3634

@avelad avelad added this to the v4.4 milestone Nov 24, 2022
@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround labels Nov 24, 2022
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@theodab theodab merged commit e89eeb6 into shaka-project:main Nov 28, 2022
@avelad avelad deleted the cea-708-max-rows branch November 28, 2022 19:46
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
joeyparrish pushed a commit that referenced this pull request Dec 8, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error thrown in CEA 708 window when indicated row count in packet is 15
3 participants