fix(cast): Added existence checks for MediaDecodingConfig.{audio|video} in decodingInfo(). #4796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4790.
To be honest, I'm failing to understand how a
TypeError
can happen here (this is occurring in a Casted Apple Music, non-AES-128
stream, soEME
), since:MediaDecodingConfig.keySystemConfiguration
is set.MediaDecodingConfig.keySystemConfiguration
is only set ifdrmInfos
are provided:shaka-player/lib/util/stream_utils.js
Lines 659 to 666 in 68f10a1
during manifest parsing (showing HLS for example):
shaka-player/lib/hls/hls_parser.js
Lines 1003 to 1016 in 68f10a1
Regardless,
requestMediaKeySystemAccess()
will never report a variant issupported
ifcontentType
is null/empty string (as per https://w3c.github.io/encrypted-media/#get-supported-capabilities-for-audio-video-type). So the polyfill implementation behaves the same as before this change.