fix(TTML): Fix duplicate cues overlapping segment boundaries #4798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested review from
littlespex,
avelad,
JulianDomingo and
theodab
theodab
previously approved these changes
Dec 8, 2022
littlespex
previously approved these changes
Dec 8, 2022
|
Oops, had a linter error, and fixing it dismissed your reviews. Please look again when you have a chance. |
littlespex
approved these changes
Dec 8, 2022
|
Incremental code coverage: 100.00% |
|
Waiting to confirm with @david-hm-morgan before merging, since this clobbers his PR. |
avelad
approved these changes
Dec 8, 2022
david-hm-morgan
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Yes this is a more suitable solution, I've retested with the original problematic stream and all is good.
thanks @joeyparrish
avelad
added
type: bug
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4631