Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chapters): removed duplicate chapters by id #4810

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

WINOFFRG
Copy link
Contributor

@WINOFFRG WINOFFRG commented Dec 9, 2022

fixes #4750

Solved by creating a Set for filtering out deplicate elements.

Need confirmation, Shouldn't we add an assert for language argument passed to

shaka-player/lib/player.js

Lines 4340 to 4342 in 76f96b9

getChapters(language) {
const LanguageUtils = shaka.util.LanguageUtils;
const inputlanguage = LanguageUtils.normalize(language);

@google-cla
Copy link

google-cla bot commented Dec 9, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Incremental code coverage: 100.00%

@joeyparrish
Copy link
Member

Shouldn't we add an assert for language argument passed to
getChapters(language) {

I don't know what you mean by that. What assertion do you want to add?

Assertions are removed in production builds, and are generally only used in this project to catch mistaken internal assumptions or to manage nullability checks at the compiler level.

@joeyparrish
Copy link
Member

Looks good to me, but I'll give @avelad a chance to take a look, too. I'll merge it Monday morning if there are no other comments. (My work-week will be over in a few hours.)

@avelad
Copy link
Member

avelad commented Dec 9, 2022

I’ll review it tomorrow

@avelad avelad added this to the v4.4 milestone Dec 10, 2022
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Dec 10, 2022
@avelad avelad merged commit 151bdda into shaka-project:main Dec 10, 2022
joeyparrish pushed a commit that referenced this pull request Dec 14, 2022
fixes #4750

Solved by creating a `Set` for filtering out deplicate elements.

Need confirmation, Shouldn't we add an `assert` for `language` argument
passed to
https://github.com/shaka-project/shaka-player/blob/76f96b9fee2dc43b03f6803dd80c51fdc5b73a9e/lib/player.js#L4340-L4342
joeyparrish pushed a commit that referenced this pull request Dec 14, 2022
fixes #4750

Solved by creating a `Set` for filtering out deplicate elements.

Need confirmation, Shouldn't we add an `assert` for `language` argument
passed to
https://github.com/shaka-project/shaka-player/blob/76f96b9fee2dc43b03f6803dd80c51fdc5b73a9e/lib/player.js#L4340-L4342
joeyparrish pushed a commit that referenced this pull request Dec 14, 2022
fixes #4750

Solved by creating a `Set` for filtering out deplicate elements.

Need confirmation, Shouldn't we add an `assert` for `language` argument
passed to
https://github.com/shaka-project/shaka-player/blob/76f96b9fee2dc43b03f6803dd80c51fdc5b73a9e/lib/player.js#L4340-L4342
joeyparrish pushed a commit that referenced this pull request Dec 14, 2022
fixes #4750

Solved by creating a `Set` for filtering out deplicate elements.

Need confirmation, Shouldn't we add an `assert` for `language` argument
passed to
https://github.com/shaka-project/shaka-player/blob/76f96b9fee2dc43b03f6803dd80c51fdc5b73a9e/lib/player.js#L4340-L4342
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Feb 8, 2023
fixes shaka-project#4750

Solved by creating a `Set` for filtering out deplicate elements.

Need confirmation, Shouldn't we add an `assert` for `language` argument
passed to
https://github.com/shaka-project/shaka-player/blob/76f96b9fee2dc43b03f6803dd80c51fdc5b73a9e/lib/player.js#L4340-L4342
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addChaptersTrack work in append mode, Expected?
3 participants