-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chapters): removed duplicate chapters by id #4810
fix(chapters): removed duplicate chapters by id #4810
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Incremental code coverage: 100.00% |
I don't know what you mean by that. What assertion do you want to add? Assertions are removed in production builds, and are generally only used in this project to catch mistaken internal assumptions or to manage nullability checks at the compiler level. |
Looks good to me, but I'll give @avelad a chance to take a look, too. I'll merge it Monday morning if there are no other comments. (My work-week will be over in a few hours.) |
I’ll review it tomorrow |
fixes #4750 Solved by creating a `Set` for filtering out deplicate elements. Need confirmation, Shouldn't we add an `assert` for `language` argument passed to https://github.com/shaka-project/shaka-player/blob/76f96b9fee2dc43b03f6803dd80c51fdc5b73a9e/lib/player.js#L4340-L4342
fixes #4750 Solved by creating a `Set` for filtering out deplicate elements. Need confirmation, Shouldn't we add an `assert` for `language` argument passed to https://github.com/shaka-project/shaka-player/blob/76f96b9fee2dc43b03f6803dd80c51fdc5b73a9e/lib/player.js#L4340-L4342
fixes #4750 Solved by creating a `Set` for filtering out deplicate elements. Need confirmation, Shouldn't we add an `assert` for `language` argument passed to https://github.com/shaka-project/shaka-player/blob/76f96b9fee2dc43b03f6803dd80c51fdc5b73a9e/lib/player.js#L4340-L4342
fixes #4750 Solved by creating a `Set` for filtering out deplicate elements. Need confirmation, Shouldn't we add an `assert` for `language` argument passed to https://github.com/shaka-project/shaka-player/blob/76f96b9fee2dc43b03f6803dd80c51fdc5b73a9e/lib/player.js#L4340-L4342
fixes shaka-project#4750 Solved by creating a `Set` for filtering out deplicate elements. Need confirmation, Shouldn't we add an `assert` for `language` argument passed to https://github.com/shaka-project/shaka-player/blob/76f96b9fee2dc43b03f6803dd80c51fdc5b73a9e/lib/player.js#L4340-L4342
fixes #4750
Solved by creating a
Set
for filtering out deplicate elements.Need confirmation, Shouldn't we add an
assert
forlanguage
argument passed toshaka-player/lib/player.js
Lines 4340 to 4342 in 76f96b9