fix: Fix duplicate updates in StreamingEngine #4840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several places where certain StreamingEngine events and timing could result in duplicate update requests for streams. This caused some inconsistent test failures, in particular on Chromecast. This change adds some additional checks before scheduling and cancelling updates, to ensure that the proper conditions are maintained. Closes shaka-project#4831
joeyparrish
requested review from
littlespex,
alekzz,
avelad and
JulianDomingo
|
Fix tested over 50 runs of StreamingEngine tests on Chromecast in our lab. Without the fix, these tests failed roughly 3 out of 10 times. With the fix, these tests never failed in 50 runs. |
avelad
added
type: bug
avelad
approved these changes
Dec 14, 2022
littlespex
approved these changes
Dec 14, 2022
|
Incremental code coverage: 92.31% |
joeyparrish
added a commit
that referenced
this pull request
Dec 14, 2022
There were several places where certain StreamingEngine events and timing could result in duplicate update requests for streams. This caused some inconsistent test failures, in particular on Chromecast. This change adds some additional checks before scheduling and cancelling updates, to ensure that the proper conditions are maintained. Closes #4831
joeyparrish
added a commit
that referenced
this pull request
Dec 14, 2022
There were several places where certain StreamingEngine events and timing could result in duplicate update requests for streams. This caused some inconsistent test failures, in particular on Chromecast. This change adds some additional checks before scheduling and cancelling updates, to ensure that the proper conditions are maintained. Closes #4831
joeyparrish
added a commit
that referenced
this pull request
Dec 14, 2022
There were several places where certain StreamingEngine events and timing could result in duplicate update requests for streams. This caused some inconsistent test failures, in particular on Chromecast. This change adds some additional checks before scheduling and cancelling updates, to ensure that the proper conditions are maintained. Closes #4831
joeyparrish
added a commit
that referenced
this pull request
Dec 14, 2022
There were several places where certain StreamingEngine events and timing could result in duplicate update requests for streams. This caused some inconsistent test failures, in particular on Chromecast. This change adds some additional checks before scheduling and cancelling updates, to ensure that the proper conditions are maintained. Closes #4831
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
There were several places where certain StreamingEngine events and timing could result in duplicate update requests for streams. This caused some inconsistent test failures, in particular on Chromecast. This change adds some additional checks before scheduling and cancelling updates, to ensure that the proper conditions are maintained. Closes shaka-project#4831
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several places where certain StreamingEngine events and timing could result in duplicate update requests for streams. This caused some inconsistent test failures, in particular on Chromecast.
This change adds some additional checks before scheduling and cancelling updates, to ensure that the proper conditions are maintained.
Closes #4831