fix: Explicitly specify @externs in transmuxer externs. #4999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianDomingo
added
the
component: build system
JulianDomingo
changed the title
|
Incremental code coverage: No instrumented code was changed. |
joeyparrish
approved these changes
Feb 14, 2023
joeyparrish
deleted the
4998-fix-prevent-transmuxerengine-externs-from-surfacing-in-shaka-playercompileddebugjs-builds
branch
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4998.
Now, building Shaka debug build will correctly obfuscate
shaka.extern.Transmuxer.*fields in theshaka-player.compiled.debug.jsbuild like all the other externs provided inexterns/shaka/directory (e.g.,aria.js, etc.).