Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MSS): Add support for Microsoft Smooth Streaming (VOD only) #5002

Merged
merged 19 commits into from
Mar 24, 2023
Merged

feat(MSS): Add support for Microsoft Smooth Streaming (VOD only) #5002

merged 19 commits into from
Mar 24, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Feb 14, 2023 •
edited
Loading

Closes #703

Live is not supported

@avelad avelad added type: enhancement New feature or request priority: P4 Nice to have / wishful thinking labels Feb 14, 2023
@avelad avelad added this to the v4.4 milestone Feb 14, 2023
@avelad avelad marked this pull request as draft February 14, 2023 17:48
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2023 •
edited
Loading

Incremental code coverage: 82.06%

@avelad avelad force-pushed the mss branch 5 times, most recently from 97a18c7 to 433d24f Compare February 21, 2023 18:33
@avelad avelad force-pushed the mss branch 3 times, most recently from 6398870 to 1bdc77e Compare February 23, 2023 16:15
@avelad avelad marked this pull request as ready for review February 24, 2023 14:46
@avelad avelad added the component: MSS The issue involves Microsoft Smooth Streaming manifest format label Feb 28, 2023
theodab
theodab requested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's my feedback so far. I'll start reading mss_parser.js tomorrow.

externs/shaka/manifest.js Outdated Show resolved Hide resolved
externs/shaka/manifest.js Outdated Show resolved Hide resolved
lib/mss/content_protection.js Show resolved Hide resolved
lib/mss/content_protection.js Show resolved Hide resolved
lib/mss/content_protection.js Outdated Show resolved Hide resolved
lib/mss/content_protection.js Outdated Show resolved Hide resolved
lib/mss/content_protection.js Show resolved Hide resolved
lib/mss/content_protection.js Show resolved Hide resolved
lib/mss/content_protection.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab March 5, 2023 09:02
theodab
theodab previously requested changes Mar 6, 2023
View reviewed changes
lib/mss/mss_parser.js Show resolved Hide resolved
lib/mss/mss_parser.js Outdated Show resolved Hide resolved
lib/mss/mss_parser.js Show resolved Hide resolved
lib/mss/mss_parser.js Outdated Show resolved Hide resolved
lib/mss/mss_parser.js Show resolved Hide resolved
lib/mss/mss_utils.js Outdated Show resolved Hide resolved
lib/mss/mss_utils.js Show resolved Hide resolved
lib/transmuxer/mss_transmuxer.js Show resolved Hide resolved
lib/transmuxer/mss_transmuxer.js Outdated Show resolved Hide resolved
lib/util/error.js Show resolved Hide resolved
@avelad avelad requested a review from theodab March 6, 2023 20:14
joeyparrish
joeyparrish requested changes Mar 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
demo/locales/source.json Outdated Show resolved Hide resolved
externs/shaka/transmuxer.js Show resolved Hide resolved
lib/media/streaming_engine.js Outdated Show resolved Hide resolved
lib/util/player_configuration.js Show resolved Hide resolved
lib/mss/mss_parser.js Show resolved Hide resolved
lib/mss/mss_parser.js Show resolved Hide resolved
lib/mss/mss_parser.js Outdated Show resolved Hide resolved
lib/mss/mss_parser.js Outdated Show resolved Hide resolved
lib/mss/mss_parser.js Show resolved Hide resolved
@joeyparrish joeyparrish changed the title feat(MSS): Add support to Microsoft Smooth Streaming feat(MSS): Add support for Microsoft Smooth Streaming (VOD only) Mar 23, 2023
@avelad avelad requested a review from joeyparrish March 23, 2023 19:20
joeyparrish
joeyparrish requested changes Mar 23, 2023
View reviewed changes
lib/mss/mss_parser.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from joeyparrish March 23, 2023 21:43
@avelad
Copy link
Member Author

avelad commented Mar 24, 2023

Thanks so much for all the help @joeyparrish!

@avelad avelad dismissed theodab’s stale review March 24, 2023 06:47

Joey-approved

@avelad avelad merged commit f80bf20 into shaka-project:main Mar 24, 2023
@avelad avelad deleted the mss branch March 24, 2023 06:49
@github-actions github-actions bot mentioned this pull request Mar 24, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@JulianDomingo JulianDomingo Awaiting requested review from JulianDomingo

@littlespex littlespex Awaiting requested review from littlespex

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: MSS The issue involves Microsoft Smooth Streaming manifest format priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Support smooth stream manifest parsing
3 participants
@avelad @joeyparrish @theodab