Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HLS): Get resolution from TS when load a Media Playlist #5058

Merged
merged 5 commits into from
Mar 15, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Mar 6, 2023

This is very useful when using ShakaPlayer in conjunction with an environment where you have to reserve memory for video.

@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels Mar 6, 2023
@avelad avelad added this to the v4.4 milestone Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Incremental code coverage: 78.60%

@avelad
Copy link
Member Author

avelad commented Mar 9, 2023

@theodab can you review it? Thanks!

Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to make a test for this?
Like, maybe something based on the 'parses media playlists directly' test inside the HLS unit tests?
You could just add a TS test asset, like '/base/test/test/assets/video.ts', to the list of media files the tests load, associate that with a URI when setting up the fakeNetEngine, and see if the resulting manifest has a width and height.

lib/util/exp_golomb.js Show resolved Hide resolved
@avelad avelad requested a review from theodab March 15, 2023 09:14
@avelad
Copy link
Member Author

avelad commented Mar 15, 2023

Would it be possible to make a test for this?
Like, maybe something based on the 'parses media playlists directly' test inside the HLS unit tests?
You could just add a TS test asset, like '/base/test/test/assets/video.ts', to the list of media files the tests load, associate that with a URI when setting up the fakeNetEngine, and see if the resulting manifest has a width and height.

Added the test

@theodab
Copy link
Contributor

theodab commented Mar 15, 2023

Thanks!

@avelad avelad merged commit 42a9f96 into shaka-project:main Mar 15, 2023
@avelad avelad deleted the ts-media-playlist-resolution branch March 15, 2023 11:37
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants