-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(HLS): Get resolution from TS when load a Media Playlist #5058
feat(HLS): Get resolution from TS when load a Media Playlist #5058
Conversation
Incremental code coverage: 78.60% |
@theodab can you review it? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to make a test for this?
Like, maybe something based on the 'parses media playlists directly'
test inside the HLS unit tests?
You could just add a TS test asset, like '/base/test/test/assets/video.ts'
, to the list of media files the tests load, associate that with a URI when setting up the fakeNetEngine
, and see if the resulting manifest has a width and height.
Added the test |
Thanks! |
This is very useful when using ShakaPlayer in conjunction with an environment where you have to reserve memory for video.