Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Ads): Add ads config #5085

Merged
merged 1 commit into from
Mar 14, 2023
Merged

feat(Ads): Add ads config #5085

merged 1 commit into from
Mar 14, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Mar 13, 2023

This doesn't produce any output right now, but this allow to the forks to create custom configurations for ads, and also allow future configurations to be added.

@avelad avelad added type: enhancement New feature or request component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Mar 13, 2023
@avelad avelad added this to the v4.4 milestone Mar 13, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 85.71%

@avelad avelad merged commit dfe263a into shaka-project:main Mar 14, 2023
@avelad avelad deleted the ads-config branch March 14, 2023 18:19
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants