Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stream property of request context obfuscated in production builds #5118

Merged
merged 41 commits into from
Mar 23, 2023

Conversation

littlespex
Copy link
Contributor

No description provided.

dsparacio and others added 30 commits October 29, 2020 16:06
@littlespex littlespex marked this pull request as ready for review March 23, 2023 17:33
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release labels Mar 23, 2023
@avelad avelad added this to the v4.4 milestone Mar 23, 2023
@joeyparrish
Copy link
Member

Could you rewrite the PR title to what users might need to see in a changelog? (Like Fix foo attribute missing in CMCD requests, etc) If you need to say more to elaborate, please use the PR description. Thanks!

@joeyparrish
Copy link
Member

(If this is just prework for #5119 and doesn't fix anything itself, use chore)

@littlespex
Copy link
Contributor Author

No, they are two separate issues.

@littlespex littlespex changed the title fix: move RequestContext to externs fix: stream property of request context obfuscated in production builds Mar 23, 2023
@avelad avelad merged commit 93baba2 into shaka-project:main Mar 23, 2023
@littlespex littlespex deleted the task/request-context-fix branch March 28, 2023 20:17
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants