Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a Mp4Generator #5127

Merged
merged 3 commits into from
Apr 12, 2023
Merged

feat: Add a Mp4Generator #5127

merged 3 commits into from
Apr 12, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Mar 29, 2023 •
edited
Loading

No description provided.

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Mar 29, 2023
@avelad avelad added this to the v4.4 milestone Mar 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023 •
edited
Loading

Incremental code coverage: 89.56%

@joeyparrish joeyparrish marked this pull request as draft March 29, 2023 17:12
@avelad avelad force-pushed the mp4-generator branch 3 times, most recently from ae06fa5 to 6f83d65 Compare April 3, 2023 08:44
@avelad avelad marked this pull request as ready for review April 3, 2023 09:36
theodab
theodab requested changes Apr 7, 2023
View reviewed changes
lib/util/mp4_generator.js Outdated Show resolved Hide resolved
lib/util/mp4_generator.js Outdated Show resolved Hide resolved
lib/util/mp4_generator.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab April 9, 2023 20:44
@avelad
Copy link
Member Author

avelad commented Apr 10, 2023

@theodab can you review it again? Thanks!

theodab
theodab requested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@theodab theodab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides that comment, I think.

@avelad avelad requested a review from theodab April 12, 2023 05:33
@avelad
Copy link
Member Author

avelad commented Apr 12, 2023

Thanks @theodab, I'll wait to merge it until all the tests pass. Thank you

@avelad avelad merged commit d475a73 into shaka-project:main Apr 12, 2023
@avelad avelad deleted the mp4-generator branch April 12, 2023 07:02
@github-actions github-actions bot mentioned this pull request Apr 12, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@avelad @theodab