fix(net): Fix HEAD requests in new Chromium #5180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that we no longer try to download the body of a head response, in the http fetch plugin. This is necessary due to an upcoming change to Chromium, where the body object of such responses is null. Fixes shaka-project#5164
theodab
added
type: bug
|
I'm downloading Chrome Beta now to test these changes with the new Chromium build. |
joeyparrish
approved these changes
Apr 25, 2023
|
Ok, I can confirm that this fixes the problem on Chrome Beta. |
|
Incremental code coverage: 97.10% |
|
Looks like those test failures still happen without this change, so they aren't related. I'll just go ahead and push, then. |
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
This makes it so that we no longer try to download the body of a head response, in the http fetch plugin. This is necessary due to an upcoming change to Chromium, where the body object of such responses is null. Fixes #5164
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
This makes it so that we no longer try to download the body of a head response, in the http fetch plugin. This is necessary due to an upcoming change to Chromium, where the body object of such responses is null. Fixes #5164
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
This makes it so that we no longer try to download the body of a head response, in the http fetch plugin. This is necessary due to an upcoming change to Chromium, where the body object of such responses is null. Fixes #5164
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
This makes it so that we no longer try to download the body of a head response, in the http fetch plugin. This is necessary due to an upcoming change to Chromium, where the body object of such responses is null. Fixes #5164
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
This makes it so that we no longer try to download the body of a head response, in the http fetch plugin. This is necessary due to an upcoming change to Chromium, where the body object of such responses is null. Fixes #5164
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that we no longer try to download the body of a head response, in the http fetch plugin. This is necessary due to an upcoming change to Chromium, where the body object of such responses is null.
Fixes #5164