Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DASH): Ignore minBufferTime when using LL #5285

Merged
merged 1 commit into from
Jun 12, 2023
Merged

fix(DASH): Ignore minBufferTime when using LL #5285

merged 1 commit into from
Jun 12, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 12, 2023

No description provided.

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: DASH The issue involves the MPEG DASH manifest format labels Jun 12, 2023
@avelad avelad added this to the v4.4 milestone Jun 12, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: 100.00%

@joeyparrish
Copy link
Member

I think we could reclassify this as a "fix" and cherry-pick it.

@joeyparrish joeyparrish changed the title feat(DASH): Ignore minBufferTime when using LL fix(DASH): Ignore minBufferTime when using LL Jun 12, 2023
@joeyparrish
Copy link
Member

If you disagree with classifying this as a fix, just rename it back to "feat" before merging.

@avelad avelad added type: bug Something isn't working correctly and removed type: enhancement New feature or request labels Jun 12, 2023
@avelad avelad merged commit fea46d8 into shaka-project:main Jun 12, 2023
@github-actions github-actions bot mentioned this pull request Jun 12, 2023
Merged
@avelad avelad deleted the dash-ll-min-buffer-time branch June 12, 2023 18:50
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@avelad @joeyparrish