-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DASH): Remove MIN_UPDATE_PERIOD_ to achieve better latency in Live #5286
feat(DASH): Remove MIN_UPDATE_PERIOD_ to achieve better latency in Live #5286
Conversation
Incremental code coverage: No instrumented code was changed. |
I really don't know if it makes sense to have MIN UPDATE PERIOD because it prevents it from updating when appropriate, I've tried to see the history and I can't find why it was added... In HLS, with LL we can update with the size of the last segment, and this is sometimes as little as 250ms. |
The history of this goes all the way to the beginning. We were concerned that poorly-formatted DASH content could have an unreasonably-short update period, leading the client to misbehave. We wanted to avoid updating too frequently. If you would rather have the new feature be the removal of this internal restriction, that's fine with me. The DASH ecosystem has grown up quite a bit since 2014. |
So, I'll delete it! thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some tests are failing and need to be updated.
I fixed the tests |
Many LL streams use 2 seconds segments, so we have to ensure that these streams work correctly.