Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DASH): Remove MIN_UPDATE_PERIOD_ to achieve better latency in Live #5286

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 12, 2023

Many LL streams use 2 seconds segments, so we have to ensure that these streams work correctly.

@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: DASH The issue involves the MPEG DASH manifest format labels Jun 12, 2023
@avelad avelad added this to the v4.4 milestone Jun 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 12, 2023

Incremental code coverage: No instrumented code was changed.

@avelad
Copy link
Member Author

avelad commented Jun 12, 2023

I really don't know if it makes sense to have MIN UPDATE PERIOD because it prevents it from updating when appropriate, I've tried to see the history and I can't find why it was added...

In HLS, with LL we can update with the size of the last segment, and this is sometimes as little as 250ms.

@joeyparrish
Copy link
Member

The history of this goes all the way to the beginning. We were concerned that poorly-formatted DASH content could have an unreasonably-short update period, leading the client to misbehave. We wanted to avoid updating too frequently.

If you would rather have the new feature be the removal of this internal restriction, that's fine with me. The DASH ecosystem has grown up quite a bit since 2014.

@avelad
Copy link
Member Author

avelad commented Jun 12, 2023

So, I'll delete it! thank you!

@avelad avelad changed the title feat(DASH): Change MIN_UPDATE_PERIOD_ to achieve better latency in LL feat(DASH): Remove MIN_UPDATE_PERIOD_ to achieve better latency in Live Jun 12, 2023
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some tests are failing and need to be updated.

@avelad
Copy link
Member Author

avelad commented Jun 12, 2023

I fixed the tests

@avelad avelad requested a review from joeyparrish June 12, 2023 18:58
@joeyparrish joeyparrish merged commit 1515b7a into shaka-project:main Jun 12, 2023
@avelad avelad deleted the dash-ll-min-update-period branch June 13, 2023 06:06
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants