feat(HLS): Allow delivery directives in Live streams #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
|
Incremental code coverage: 95.24% |
|
This looks fine, but I don't understand the motivation. Could you please add a description explaining why these should be sent even without LL mode enabled? Are these considered part of basic HLS now even without other LL features? Are they harmless if LL is off? Etc. |
theodab
approved these changes
Jun 13, 2023
I added a description |
joeyparrish
approved these changes
Jun 13, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis#section-6.2.5 delivery directives are allowed for all live content