Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Parses a TFDT Box, with a loss of precision beyond 53 bits #5329

Merged
merged 4 commits into from
Jun 21, 2023
Merged

feat: Parses a TFDT Box, with a loss of precision beyond 53 bits #5329

merged 4 commits into from
Jun 21, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 19, 2023 •
edited
Loading

No description provided.

@avelad avelad added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking labels Jun 19, 2023
@avelad avelad added this to the v4.4 milestone Jun 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023 •
edited
Loading

Incremental code coverage: 100.00%

@avelad avelad force-pushed the big-int-baseMediaDecodeTime branch from 57d5b1d to a63b937 Compare June 19, 2023 13:23
joeyparrish
joeyparrish requested changes Jun 20, 2023
View reviewed changes
lib/util/data_view_reader.js Outdated Show resolved Hide resolved
lib/media/media_source_engine.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from joeyparrish June 20, 2023 20:48
joeyparrish
joeyparrish requested changes Jun 20, 2023
View reviewed changes
lib/media/media_source_engine.js Outdated Show resolved Hide resolved
@avelad avelad changed the title feat: Supports baseMediaDecodeTime greater than 2^53 when BigInt is compatible feat: Parses a TFDT Box, with a loss of precision beyond 53 bits Jun 21, 2023
@avelad avelad requested a review from joeyparrish June 21, 2023 06:44
@avelad
Copy link
Member Author

avelad commented Jun 21, 2023

@joeyparrish @theodab , I changed the implementation, can you review again?

@avelad avelad merged commit db73e1f into shaka-project:main Jun 21, 2023
@avelad avelad deleted the big-int-baseMediaDecodeTime branch June 21, 2023 16:15
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
Merged
@alexgerv alexgerv mentioned this pull request Jul 11, 2023
Closed
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@avelad @joeyparrish