fix: Fix gap jump at start when first jump lands in a new gap #5408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 100.00% |
joeyparrish
approved these changes
Jul 19, 2023
joeyparrish
changed the title
joeyparrish
pushed a commit
that referenced
this pull request
Jul 20, 2023
This change accounts for a gap jump at the start of an asset that lands the user user inside of another gap. The video element is still `paused` at this point, but we've moved past the `startTime` because we jumped a gap. Thus the gap jumper gets stuck, and playback will never start.
joeyparrish
pushed a commit
that referenced
this pull request
Jul 20, 2023
This change accounts for a gap jump at the start of an asset that lands the user user inside of another gap. The video element is still `paused` at this point, but we've moved past the `startTime` because we jumped a gap. Thus the gap jumper gets stuck, and playback will never start.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change accounts for a gap jump at the start of an asset that lands the user user inside of another gap. The video element is still
pausedat this point, but we've moved past thestartTimebecause we jumped a gap. Thus the gap jumper gets stuck, and playback will never start.This seems like it should be a wild edge case, but we have some assets that reproduce it!
BEGIN_COMMIT_OVERRIDE
fix: Fix gap jump at start when first jump lands in a new gap
END_COMMIT_OVERRIDE