Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Fix playback restarts in safari when click on seekbar end #5527

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix(UI): Fix playback restarts in safari when click on seekbar end #5527

merged 1 commit into from
Aug 24, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Aug 24, 2023

Fixes #5080

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround browser: Safari Issues affecting Safari or WebKit derivatives labels Aug 24, 2023
@avelad avelad added this to the v4.4 milestone Aug 24, 2023
@avelad avelad changed the title fix(UI): FIx playback restarts in safari when click on seekbar end fix(UI): Fix playback restarts in safari when click on seekbar end Aug 24, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: No instrumented code was changed.

@avelad avelad merged commit 4235658 into shaka-project:main Aug 24, 2023
@avelad avelad deleted the ui-seek-end branch August 24, 2023 10:02
joeyparrish pushed a commit that referenced this pull request Aug 30, 2023
@avelad @joeyparrish
fix(UI): Fix playback restarts in safari when click on seekbar end (#…
8263c73 
…5527)

Fixes #5080
@github-actions github-actions bot mentioned this pull request Aug 30, 2023
Merged
joeyparrish pushed a commit that referenced this pull request Aug 30, 2023
@avelad @joeyparrish
fix(UI): Fix playback restarts in safari when click on seekbar end (#…
7824cc9 
…5527)

Fixes #5080
@github-actions github-actions bot mentioned this pull request Aug 21, 2023
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 23, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
browser: Safari Issues affecting Safari or WebKit derivatives component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Playback restarts in safari when click on seekbar end.
3 participants
@avelad @theodab @shaka-bot