feat: Add AAC silent frame getter #5557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
theodab
reviewed
Aug 30, 2023
| */ | ||
| static getSilentFrame(codec, channelCount) { | ||
| switch (codec) { | ||
| case 'mp4a.40.2': |
There was a problem hiding this comment.
Like the stuff below, is there any reference for where these values come from for mp4a.40.2? Like, any reference document that you got them from or ffmpeg command that generated them?
There was a problem hiding this comment.
|
Incremental code coverage: 7.89% |
joeyparrish
approved these changes
Aug 30, 2023
In TS sometimes not all the audio samples are included to optimize, so we are going to include it ourselves :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for enable the muxed TS transmuxer in the future.