feat(HLS): Add support for mjpg I-Frames playlist #5856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: enhancement
|
Incremental code coverage: 49.62% |
avelad
force-pushed
the
i-frame-mjpg
branch
3 times, most recently
from
8cf99d2 to
cf01dfa
Compare
theodab
requested changes
Nov 7, 2023
lib/hls/hls_parser.js
Outdated
|
|
||
| // TODO: This check is necessary because of the possibility of multiple | ||
| // calls to createStreamInfoFromImageTag_ before either has resolved. | ||
| if (this.uriToStreamInfosMap_.has(verbatimIFramePlaylistUri)) { |
There was a problem hiding this comment.
Also I'm not sure we need this check anymore, in this function or in createStreamInfoFromImageTag_. There is no context switch between this and the previous check to uriToStreamInfosMap_.
Looking at git blame, createStreamInfo_ used to be async, but in #4511 it was changed to be synchronous. It looks like, at the time, I didn't notice that made this check unnecessary.
There was a problem hiding this comment.
Yes, it is no longer necessary, I delete it.
There was a problem hiding this comment.
I take advantage of this PR to eliminate this same thing on other sites where it is not necessary.
theodab
approved these changes
Nov 8, 2023
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
It also adds support for rendering downloaded thumbnails.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also adds support for rendering downloaded thumbnails.