fix: CEA decoder should return early if packet is not large enough #5893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
approved these changes
Nov 15, 2023
tomhaines432
approved these changes
Nov 15, 2023
|
Incremental code coverage: 100.00% |
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
…haka-project#5893) Fixes shaka-project#5891 In production, we are seeing the occasional SEI packet [`0x5b`], which is causing the parser to error. Using Mux.JS, this packet is ignored because it's not long enough to be a valid captions packet, so for feature parity it would make sense for the built in Shaka parser to also ignore.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5891
In production, we are seeing the occasional SEI packet [
0x5b], which is causing the parser to error. Using Mux.JS, this packet is ignored because it's not long enough to be a valid captions packet, so for feature parity it would make sense for the built in Shaka parser to also ignore.