Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI): Hide language and resolution overflow menu button if there's only one choice #5928

Merged
merged 1 commit into from
Nov 27, 2023
Merged

feat(UI): Hide language and resolution overflow menu button if there's only one choice #5928

merged 1 commit into from
Nov 27, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Nov 24, 2023

Closes #4720

@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent labels Nov 24, 2023
@avelad avelad added this to the v5.0 milestone Nov 24, 2023
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 628bb63 into shaka-project:main Nov 27, 2023
@shaka-bot shaka-bot mentioned this pull request Nov 27, 2023
Merged
@avelad avelad deleted the ui-hide-overflow-one-item branch November 27, 2023 08:02
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
feat(UI): Hide language and resolution overflow menu button if there'…
f858e42 
…s only one choice (shaka-project#5928)

Closes shaka-project#4720
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 26, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

Way to conditionally hide audio language overflow menu button if there's only one language
3 participants
@avelad @shaka-bot @theodab