fix: Properly size region anchor from LINE units #5941
Merged
+51
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With shaka-project#5924, 708 windows were exposed as Cue regions. Since the region ID was getting set now, the UITextDisplayer was trying to position the regions but it doesn't properly support LINES units. This PR skips positioning the region if the values are in LINES units until that can be properly implemented.
|
Incremental code coverage: 54.05% |
gkatsev
commented
Nov 28, 2023
lib/text/ui_text_displayer.js
Outdated
| if (region.heightUnits === linesUnit && region.widthUnits === linesUnit) { | ||
| // from https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#caption-window-size | ||
| regionElement.style.height = region.height * 5.33 + '%'; | ||
| regionElement.style.width = region.width * 1.9 + '%'; |
There was a problem hiding this comment.
Currently, assuming the video's aspect ratio is 16:9. 708 captions only know about 4:3 and 16:9 video. Happy to do a check here to figure out the correct multiple here but need a pointer to how to figure it out.
There was a problem hiding this comment.
I have added a commit to this PR to calculate the aspect ratio, you just have to use the variable this.aspectRatio_
avelad
changed the title
avelad
added
type: bug
|
Provides more improvements to #2583 |
|
This does implement region anchors, but the issue talks about WebVTT and IMSC/TTML, and I was mostly focused on 708. It's possible that this also solves the WebVTT portion fully, but I'm not sure about the IMSC/TTML portion. |
theodab
approved these changes
Nov 28, 2023
avelad
added a commit
that referenced
this pull request
Nov 30, 2023
CEA708 captions may set windows in LINE units, this needs to be converted to percentages to be properly displayed. In addition, adjust by the region anchor. --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Nov 30, 2023
CEA708 captions may set windows in LINE units, this needs to be converted to percentages to be properly displayed. In addition, adjust by the region anchor. --------- Co-authored-by: Álvaro Velad Galván <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CEA708 captions may set windows in LINE units, this needs to be converted to percentages to be properly displayed. In addition, adjust by the region anchor.