perf: Improve performance of addThumbnailsTrack #6067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: performance
theodab
previously requested changes
Jan 10, 2024
| [uri], [cue.payload])[0]; | ||
| let uris = null; | ||
| const getUris = () => { | ||
| if (uris == null) { |
There was a problem hiding this comment.
I understand why not resolving all of the uris at once in a huge thumbnails track might improve performance, but is there a specific reason we want to no longer use shaka.util.ManifestParserUtils.resolveUris for this? It seems like it'd be a smaller change for getUris to just be something like:
const getUris = () => {
if (uris == null) {
uris = shaka.util.ManifestParserUtils.resolveUris([uri], [cue.playload]);
}
return uris || [];
};
littlespex
approved these changes
Jan 10, 2024
avelad
added a commit
that referenced
this pull request
Jan 11, 2024
avelad
added a commit
that referenced
this pull request
Jan 11, 2024
joeyparrish
pushed a commit
that referenced
this pull request
Feb 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6065