feat: SegmentIndex minimal interface #6095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tykus160
changed the title
avelad
added
type: enhancement
littlespex
approved these changes
Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: we (Sky/Peacock) were working on custom manifest parser and we wanted to use similar approach to
shaka.dash.TimelineSegmentIndexbut adjusted to our needs and data structure.So similar to that, we extended base
SegmentIndexclass with our implementation, butMetaSegmentIndexdidn't work correctly with this implementation due to 2 issues:MetaSegmentIndexuses protectednumEvicted_field that we cannot modify externally in any way.getNumEvicted()method wasn't enough, because Closure Compiler optimization was aliasing internal call to this method inMetaSegmentIndexfor some reason.By moving crucial APIs to extern we can overcome this issue. Still, preferred way of using own SegmentIndex implementation is by extending base class, as it offers SegmentIterator out of the box.