Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(UI): Use the same logic to group variants into audio and quality selectors #6096

Merged
merged 1 commit into from
Jan 16, 2024
Merged

feat(UI): Use the same logic to group variants into audio and quality selectors #6096

merged 1 commit into from
Jan 16, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 12, 2024

Closes #6039

@avelad avelad added type: enhancement New feature or request component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent labels Jan 12, 2024
@avelad avelad added this to the v5.0 milestone Jan 12, 2024
@avelad avelad requested a review from theodab January 12, 2024 14:53
@avelad
Copy link
Member Author

avelad commented Jan 12, 2024

@absidue FYI

@avelad avelad force-pushed the ui-quality-role-label branch from fdfe885 to 61f28ad Compare January 12, 2024 15:06
@absidue
Copy link

absidue commented Jan 13, 2024

This works perfectly, thank you so much :).

@avelad avelad requested a review from littlespex January 15, 2024 07:11
@avelad avelad merged commit c596677 into shaka-project:main Jan 16, 2024
12 of 16 checks passed
@avelad avelad deleted the ui-quality-role-label branch January 16, 2024 08:29
@shaka-bot shaka-bot mentioned this pull request Jan 16, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Mar 16, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.8
Development

Successfully merging this pull request may close these issues.

UI: Audio track selector and quality selector should use the same logic to group variants into audio tracks
4 participants
@avelad @absidue @theodab @shaka-bot