-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UI): Add config for refreshTickInSeconds #6386
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@MarianoFacundoArch Please add your name and email to https://github.com/shaka-project/shaka-player/blob/main/AUTHORS and https://github.com/shaka-project/shaka-player/blob/main/CONTRIBUTORS (alphabetically please). Thanks! |
@avelad Name added to this PR as requested; how do we proceed and get it merged? |
Incremental code coverage: 100.00% |
We need a review from @joeyparrish or @theodab before merge it. Thanks! |
When shall this be released? In which version? |
If we don't do a new branch for v4.8, this would be out in v5.0, which we will be more cautious about. There are other things we want to break this year, like moving to TypeScript, so it's possible that v5.0 will be delayed for a while. If we create a v4.8.x branch without the breaking changes in it, your change would be in that branch and would be out sooner. |
We will be releasing v4.8.0 soon. |
Got it. Thank you @joeyparrish ! |
Closes #6376