Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Ads): Support CS on devices that don't support multiple media elements #6575

Merged
merged 69 commits into from
May 23, 2024
Merged

feat(Ads): Support CS on devices that don't support multiple media elements #6575

merged 69 commits into from
May 23, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented May 10, 2024

Closes #2792

@avelad avelad added type: enhancement New feature or request platform: TV/STB Issues affecting smart TV or set-top box platforms component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround platform: Cast Issues affecting Cast devices platform: WebOS Issues affecting WebOS platform: Tizen Issues affecting Tizen labels May 10, 2024
@avelad avelad added this to the v4.9 milestone May 10, 2024
@avelad avelad marked this pull request as draft May 10, 2024 09:01
@avelad avelad force-pushed the cs-devices-without-multiple-media-elements branch from 39e5abd to 814ad85 Compare May 10, 2024 09:04
@shaka-bot
Copy link
Collaborator

shaka-bot commented May 10, 2024 •
edited
Loading

Incremental code coverage: 95.71%

@avelad avelad force-pushed the cs-devices-without-multiple-media-elements branch from 814ad85 to 7f41b85 Compare May 10, 2024 09:25
avelad added a commit to avelad/shaka-player that referenced this pull request May 14, 2024
@avelad
Debug 6001 error in shaka-project#6575
27acfb4
@avelad avelad marked this pull request as ready for review May 22, 2024 10:22
@avelad avelad requested a review from theodab May 22, 2024 10:23
joeyparrish
joeyparrish previously requested changes May 22, 2024
View reviewed changes
@avelad avelad requested a review from joeyparrish May 22, 2024 19:04
@avelad
Copy link
Member Author

avelad commented May 22, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6575

@avelad avelad dismissed joeyparrish’s stale review May 23, 2024 07:25

Changes addressed

@avelad avelad merged commit 520930c into shaka-project:main May 23, 2024
31 checks passed
@shaka-bot shaka-bot mentioned this pull request May 23, 2024
Merged
@avelad avelad deleted the cs-devices-without-multiple-media-elements branch May 23, 2024 07:37
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 22, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs platform: Cast Issues affecting Cast devices platform: Tizen Issues affecting Tizen platform: TV/STB Issues affecting smart TV or set-top box platforms platform: WebOS Issues affecting WebOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.9
4 participants
@avelad @shaka-bot @joeyparrish @theodab