Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(UI): Don't show presentation time in ads #6752

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 4, 2024

This bug has been detected when implementing HLS interstitials

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround labels Jun 4, 2024
@avelad avelad added this to the v4.10 milestone Jun 4, 2024
@avelad avelad requested review from littlespex, theodab and joeyparrish and removed request for littlespex June 4, 2024 18:02
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 2e4ace5 into shaka-project:main Jun 4, 2024
21 of 23 checks passed
joeyparrish pushed a commit that referenced this pull request Jun 4, 2024
This bug has been detected when implementing HLS interstitials
joeyparrish pushed a commit that referenced this pull request Jun 4, 2024
This bug has been detected when implementing HLS interstitials
joeyparrish pushed a commit that referenced this pull request Jun 5, 2024
This bug has been detected when implementing HLS interstitials
@avelad avelad deleted the ui-ads-live branch June 5, 2024 06:19
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 3, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants