Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HLS): Ignore EXT-X-DATERANGE in the past #6757

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 5, 2024

No description provided.

@avelad
Copy link
Member Author

avelad commented Jun 5, 2024

The change is feat instead of fix because the functionality it fixes has not been released in any release.

@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Jun 5, 2024
@avelad avelad added this to the v4.10 milestone Jun 5, 2024
@avelad avelad requested review from joeyparrish and theodab June 5, 2024 08:09
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit 8d7dd37 into shaka-project:main Jun 5, 2024
14 of 15 checks passed
@avelad avelad deleted the daterange-past branch June 5, 2024 11:13
@joeyparrish
Copy link
Member

Why is this useful? I'm not deeply familiar with the use of DATERANGE.

@avelad
Copy link
Member Author

avelad commented Jun 6, 2024

Why is this useful? I'm not deeply familiar with the use of DATERANGE.

Some packagers save the daterange for a few days in the playlist even if the playlist is only for today or a few hours. So these dateranges prior to our start of the stream are of no use.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 4, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Aug 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants